mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-27 06:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Protect HTTP cache entries from garbage collector

Browse source 
One day we'll have an eviction strategy, too, but for now let's not
allow these to get collected.

Co-Authored-By: Gingeh <39150378+Gingeh@users.noreply.github.com>
This commit is contained in:
Andreas Kling 2024-12-25 15:52:50 +01:00 • committed by Andreas Kling
parent 08589741f5
commit 56e6d4f42d
Notes: github-actions[bot] 2024-12-25 16:12:07 +00:00
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View file

@ -1374,7 +1374,7 @@ public:
// FIXME: - the stored response does not contain the no-cache directive (Section 5.2.2.4), unless it is successfully validated (Section 4.3), and
initial_set_of_stored_responses.append(cached_response);
initial_set_of_stored_responses.append(*cached_response);
// FIXME: - the stored response is one of the following:
// + fresh (see Section 4.2), or
@ -1383,7 +1383,7 @@ public:
dbgln("\033[32;1mHTTP CACHE HIT!\033[0m {}", url);
return cached_response;
return cached_response.ptr();
}
void store_response(JS::Realm& realm, Infrastructure::Request const& http_request, Infrastructure::Response const& response)
@ -1584,7 +1584,7 @@ private:
return true;
}
HashMap<URL::URL, GC::Ptr<Infrastructure::Response>> m_cache;
HashMap<URL::URL, GC::Root<Infrastructure::Response>> m_cache;
};
class HTTPCache {
@ -1645,7 +1645,7 @@ WebIDL::ExceptionOr<GC::Ref<PendingResponse>> http_network_or_cache_fetch(JS::Re
// 5. Let storedResponse be null.
GC::Ptr<Infrastructure::Response> stored_response;
Vector<GC::Ptr<Infrastructure::Response>> initial_set_of_stored_responses;
GC::MarkedVector<GC::Ptr<Infrastructure::Response>> initial_set_of_stored_responses(realm.heap());
// 6. Let httpCache be null.
// (Typeless until we actually implement it, needed for checks below)