mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 18:50:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

ClangPlugins: Check for strong root fields in GC allocated objects

Browse source 
GC-allocated objects should never have JS::SafeFunction/JS::Handle
fields.

For now the plugin only emits warnings here, as there are many cases
of this occurring in the codebase that aren't trivial to fix. It is also
behind a CMake flag since it is a _very_ loud warning.
This commit is contained in:
Matthew Olsson 2024-05-19 11:31:47 -07:00 • committed by Andrew Kaster
commit 5740f93ef4
Notes: sideshowbarker 2024-07-17 01:53:23 +09:00
6 changed files with 141 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Meta/Lagom/ClangPlugins/LibJSGCPluginAction.h
View file

@ -53,9 +53,10 @@ private:
class LibJSGCVisitor : public clang::RecursiveASTVisitor<LibJSGCVisitor> {
public:
explicit LibJSGCVisitor(clang::ASTContext& context, LibJSCellMacroMap const& macro_map)
explicit LibJSGCVisitor(clang::ASTContext& context, LibJSCellMacroMap const& macro_map, bool detect_invalid_function_members)
: m_context(context)
, m_macro_map(macro_map)
, m_detect_invalid_function_members(detect_invalid_function_members)
{
}
@ -72,33 +73,39 @@ private:
clang::ASTContext& m_context;
LibJSCellMacroMap const& m_macro_map;
bool m_detect_invalid_function_members;
};
class LibJSGCASTConsumer : public clang::ASTConsumer {
public:
explicit LibJSGCASTConsumer(clang::CompilerInstance&);
LibJSGCASTConsumer(clang::CompilerInstance&, bool detect_invalid_function_members);
private:
virtual void HandleTranslationUnit(clang::ASTContext& context) override;
clang::CompilerInstance& m_compiler;
LibJSCellMacroMap m_macro_map;
bool m_detect_invalid_function_members;
};
class LibJSGCPluginAction : public clang::PluginASTAction {
public:
virtual bool ParseArgs(clang::CompilerInstance const&, std::vector<std::string> const&) override
virtual bool ParseArgs(clang::CompilerInstance const&, std::vector<std::string> const& args) override
{
m_detect_invalid_function_members = std::find(args.begin(), args.end(), "detect-invalid-function-members") != args.end();
return true;
}
virtual std::unique_ptr<clang::ASTConsumer> CreateASTConsumer(clang::CompilerInstance& compiler, llvm::StringRef) override
{
return std::make_unique<LibJSGCASTConsumer>(compiler);
return std::make_unique<LibJSGCASTConsumer>(compiler, m_detect_invalid_function_members);
}
ActionType getActionType() override
{
return AddAfterMainAction;
}
private:
bool m_detect_invalid_function_members { false };
};