mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-24 05:25:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK+TestSuite: Don't assume that the test passed in output.

Browse source 
The problem with our test suite is that it can't detect if a test
failed. When a test fails we simply write 'FAIL ...' to stderr and move
on.

Previously, the test suite would list all tests as passing regardless
how many assertions failed. In the future it might be smart to implement
this properly but test suites for C++ are always hard to do nicely.
(Because C++ execution isn't meant to be embedded.)
This commit is contained in:
asynts 2020-09-28 14:36:08 +02:00 • committed by Andreas Kling
parent 9225bfa95e
commit 574f49e4be
Notes: sideshowbarker 2024-07-19 02:08:52 +09:00
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
AK/TestSuite.h
View file

@ -164,7 +164,7 @@ void TestSuite::main(const String& suite_name, int argc, char** argv)
out() << " " << test.name();
}
} else {
out() << "Running " << matching_tests.size() << " cases out of " << m_cases.size();
out() << "Running " << matching_tests.size() << " cases out of " << m_cases.size() << ".";
run(matching_tests);
}
@ -199,13 +199,13 @@ void TestSuite::run(const NonnullRefPtrVector<TestCase>& tests)
for (const auto& t : tests) {
const auto test_type = t.is_benchmark() ? "benchmark" : "test";
dbg() << "START Running " << test_type << " " << t.name();
warnf("Running {} '{}'.", test_type, t.name());
TestElapsedTimer timer;
t.func()();
const auto time = timer.elapsed_milliseconds();
warn() << "\033[32;1mPASS\033[0m: " << time << " ms running " << test_type << " " << t.name();
dbgf("Completed {} '{}' in {}ms", test_type, t.name(), time);
if (t.is_benchmark()) {
m_benchtime += time;