mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-28 23:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Support appearance: none for <progress> elements

Browse source 
This disables this system progress bar, and instead creates one
out of pseudo elements, that can be selected and styled with the
::-webkit-progress-bar/value selectors.
This commit is contained in:
MacDue 2022-07-22 16:08:03 +01:00 • committed by Andreas Kling
parent d7d34d88e5
commit 57c6792458
Notes: sideshowbarker 2024-07-17 08:38:05 +09:00
3 changed files with 53 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

37
Userland/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
View file

@ -1,10 +1,15 @@
/*
* Copyright (c) 2020-2022, the SerenityOS developers.
* Copyright (c) 2022, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/ShadowRoot.h>
#include <LibWeb/HTML/HTMLProgressElement.h>
#include <LibWeb/Layout/BlockContainer.h>
#include <LibWeb/Layout/Node.h>
#include <LibWeb/Layout/Progress.h>
#include <stdlib.h>
@ -19,7 +24,29 @@ HTMLProgressElement::~HTMLProgressElement() = default;
RefPtr<Layout::Node> HTMLProgressElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)
{
return adopt_ref(*new Layout::Progress(document(), *this, move(style)));
RefPtr<Layout::Node> layout_node;
if (style->appearance().value_or(CSS::Appearance::Auto) == CSS::Appearance::None) {
layout_node = adopt_ref(*new Layout::BlockContainer(document(), this, move(style)));
layout_node->set_inline(true);
} else {
layout_node = adopt_ref(*new Layout::Progress(document(), *this, move(style)));
}
return layout_node;
}
bool HTMLProgressElement::using_system_appearance() const
{
if (layout_node())
return is<Layout::Progress>(*layout_node());
return false;
}
void HTMLProgressElement::progress_position_updated()
{
if (using_system_appearance())
layout_node()->set_needs_display();
else
document().invalidate_layout();
}
double HTMLProgressElement::value() const
@ -41,9 +68,7 @@ void HTMLProgressElement::set_value(double value)
return;
set_attribute(HTML::AttributeNames::value, String::number(value));
if (layout_node())
layout_node()->set_needs_display();
progress_position_updated();
}
double HTMLProgressElement::max() const
@ -65,9 +90,7 @@ void HTMLProgressElement::set_max(double value)
return;
set_attribute(HTML::AttributeNames::max, String::number(value));
if (layout_node())
layout_node()->set_needs_display();
progress_position_updated();
}
double HTMLProgressElement::position() const