mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-27 14:58:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS/Bytecode: Make primitive bigints be constants

Browse source 
Instead of emitting a NewBigInt instruction to construct a primitive
bigint from a parsed literal, we now instantiate the BigInt on the heap
during codegen.
This commit is contained in:
Andreas Kling 2024-03-03 11:40:00 +01:00
parent 46d209c55b
commit 5813df21c8
Notes: sideshowbarker 2024-07-17 07:38:17 +09:00
4 changed files with 4 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -63,6 +63,8 @@ static ByteString format_operand(StringView name, Operand operand, Bytecode::Exe
builder.appendff("Int32({})", value.as_i32());
else if (value.is_double())
builder.appendff("Double({})", value.as_double());
else if (value.is_bigint())
builder.appendff("BigInt({})", value.as_bigint().to_byte_string());
else if (value.is_string())
builder.appendff("String(\"{}\")", value.as_string().utf8_string_view());
else if (value.is_undefined())
@ -854,13 +856,6 @@ static ThrowCompletionOr<Value> typeof_(VM& vm, Value value)
JS_ENUMERATE_COMMON_UNARY_OPS(JS_DEFINE_COMMON_UNARY_OP)
ThrowCompletionOr<void> NewBigInt::execute_impl(Bytecode::Interpreter& interpreter) const
{
auto& vm = interpreter.vm();
interpreter.set(dst(), BigInt::create(vm, m_bigint));
return {};
}
ThrowCompletionOr<void> NewArray::execute_impl(Bytecode::Interpreter& interpreter) const
{
auto array = MUST(Array::create(interpreter.realm(), 0));
@ -1613,13 +1608,6 @@ ByteString Mov::to_byte_string_impl(Bytecode::Executable const& executable) cons
format_operand("src"sv, m_src, executable));
}
ByteString NewBigInt::to_byte_string_impl(Bytecode::Executable const& executable) const
{
return ByteString::formatted("NewBigInt {}, {}",
format_operand("dst"sv, dst(), executable),
m_bigint.to_base_deprecated(10));
}
ByteString NewArray::to_byte_string_impl(Bytecode::Executable const& executable) const
{
StringBuilder builder;