mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-23 00:19:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb+LibWasm: Reject module instantiation with correct error type

Browse source 
The spec tells us to reject the promise with a RuntimeError instead of a
LinkError whenever the module's start function fails during module
instantiation. Fixes 1 WPT subtest in `wasm/core`.
This commit is contained in:
Jelle Raaijmakers 2025-07-25 14:28:29 +02:00 • committed by Jelle Raaijmakers
commit 58c3a391a3
Notes: github-actions[bot] 2025-07-25 13:14:45 +00:00
6 changed files with 128 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp
View file

@ -387,12 +387,11 @@ InstantiationResult AbstractMachine::instantiate(Module const& module, Vector<Ex
if (module.start_section().function().has_value()) {
auto& functions = main_module_instance.functions();
auto index = module.start_section().function()->index();
if (functions.size() <= index.value()) {
if (functions.size() <= index.value())
return InstantiationError { ByteString::formatted("Start section function referenced invalid index {} of max {} entries", index.value(), functions.size()) };
}
auto result = invoke(functions[index.value()], {});
if (result.is_trap())
return InstantiationError { "Start function trapped", move(result.trap()) };
return InstantiationError { "Start function trapped", move(result.trap()), InstantiationErrorSource::StartFunction };
}
return InstantiationResult { move(main_module_instance_pointer) };