mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-05 07:39:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb+LibWasm: Reject module instantiation with correct error type

Browse source 
The spec tells us to reject the promise with a RuntimeError instead of a
LinkError whenever the module's start function fails during module
instantiation. Fixes 1 WPT subtest in `wasm/core`.
This commit is contained in:
Jelle Raaijmakers 2025-07-25 14:28:29 +02:00 • committed by Jelle Raaijmakers
commit 58c3a391a3
Notes: github-actions[bot] 2025-07-25 13:14:45 +00:00
6 changed files with 128 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/WebAssembly/WebAssembly.cpp
View file

@ -397,9 +397,17 @@ JS::ThrowCompletionOr<NonnullOwnPtr<Wasm::ModuleInstance>> instantiate_module(JS
return vm.throw_completion<LinkError>(MUST(builder.to_string()));
}
// https://webassembly.github.io/spec/js-api/index.html#instantiate-the-core-of-a-webassembly-module
auto instance_result = cache.abstract_machine().instantiate(module, link_result.release_value());
if (instance_result.is_error()) {
return vm.throw_completion<LinkError>(instance_result.error().error);
auto instantiation_error = instance_result.release_error();
switch (instantiation_error.source) {
case Wasm::InstantiationErrorSource::Linking:
return vm.throw_completion<LinkError>(instantiation_error.error);
case Wasm::InstantiationErrorSource::StartFunction:
return vm.throw_completion<RuntimeError>(instantiation_error.error);
}
VERIFY_NOT_REACHED();
}
return instance_result.release_value();