From 5a9d538acc4fbea47a38def5769167a923f9f947 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 27 Oct 2024 18:26:28 +0100 Subject: [PATCH] LibWeb: Disallow `none` for `min-width` and `min-height` --- .../css/css-sizing/parsing/min-height-invalid.txt | 6 +++--- .../wpt-import/css/css-sizing/parsing/min-width-invalid.txt | 6 +++--- Userland/Libraries/LibWeb/CSS/Properties.json | 6 ++---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-invalid.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-invalid.txt index 6fb13b1bd36..d0ec61b6f18 100644 --- a/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-invalid.txt +++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-height-invalid.txt @@ -6,10 +6,10 @@ Rerun Found 11 tests -9 Pass -2 Fail +10 Pass +1 Fail Details -Result Test Name MessageFail e.style['min-height'] = "none" should not set the property value assert_equals: expected "" but got "none" +Result Test Name MessagePass e.style['min-height'] = "none" should not set the property value Pass e.style['min-height'] = "complex" should not set the property value Pass e.style['min-height'] = "-10%" should not set the property value Pass e.style['min-height'] = "-0.5em" should not set the property value diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-width-invalid.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-width-invalid.txt index d83a0513228..9b331fd9714 100644 --- a/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-width-invalid.txt +++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-sizing/parsing/min-width-invalid.txt @@ -6,10 +6,10 @@ Rerun Found 11 tests -9 Pass -2 Fail +10 Pass +1 Fail Details -Result Test Name MessageFail e.style['min-width'] = "none" should not set the property value assert_equals: expected "" but got "none" +Result Test Name MessagePass e.style['min-width'] = "none" should not set the property value Pass e.style['min-width'] = "complex" should not set the property value Pass e.style['min-width'] = "-10%" should not set the property value Pass e.style['min-width'] = "-0.5em" should not set the property value diff --git a/Userland/Libraries/LibWeb/CSS/Properties.json b/Userland/Libraries/LibWeb/CSS/Properties.json index 443770dcd18..1be6bd2bd60 100644 --- a/Userland/Libraries/LibWeb/CSS/Properties.json +++ b/Userland/Libraries/LibWeb/CSS/Properties.json @@ -1947,8 +1947,7 @@ "percentage [0,∞]" ], "valid-identifiers": [ - "auto", - "none" + "auto" ], "percentages-resolve-to": "length", "quirks": [ @@ -1974,8 +1973,7 @@ "auto", "fit-content", "max-content", - "min-content", - "none" + "min-content" ], "percentages-resolve-to": "length", "quirks": [