mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-03 22:59:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Don't leak class field initializers

Browse source 
We were storing these in Handle (strong GC roots) hanging off of
ECMAScriptFunctionObject which effectively turned into world leaks.
This commit is contained in:
Andreas Kling 2024-11-10 13:03:38 +01:00 • committed by Andreas Kling
commit 5aa1d7837f
Notes: github-actions[bot] 2024-11-10 18:13:56 +00:00
4 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Object.cpp
View file

@ -663,9 +663,9 @@ ThrowCompletionOr<void> Object::define_field(ClassFieldDefinition const& field)
auto init_value = js_undefined();
// 3. If initializer is not empty, then
if (!initializer.is_null()) {
if (initializer) {
// a. Let initValue be ? Call(initializer, receiver).
init_value = TRY(call(vm, initializer.cell(), this));
init_value = TRY(call(vm, initializer, this));
}
// 4. Else, let initValue be undefined.