mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Add tokenize() method to style values, to get a list of CVs

Browse source 
A couple of arbitrary substitution functions require us to get or
produce some style value, and then substitute its ComponentValues into
the original ComponentValue list. So this commit gives CSSStyleValue a
tokenize() method that does so.

Apart from a couple of unusual cases like the guaranteed-invalid value,
style values can all be converted into ComponentValues by serializing
them as a string, and then parsing that as a list of component values.
That feels unnecessarily inefficient in most cases though, so I've
implemented faster overrides for a lot of the basic style value
classes, but left that serialize-and-reparse method as the fallback.
This commit is contained in:
Sam Atkins 2025-07-10 12:17:27 +01:00 • committed by Tim Ledbetter
commit 5aba457009
Notes: github-actions[bot] 2025-07-16 13:50:05 +00:00
17 changed files with 90 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/CSS/StyleValues/CustomIdentStyleValue.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2023-2025, Sam Atkins <sam@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -8,6 +8,7 @@
#include <AK/FlyString.h>
#include <LibWeb/CSS/CSSStyleValue.h>
#include <LibWeb/CSS/Parser/ComponentValue.h>
namespace Web::CSS {
@ -23,6 +24,10 @@ public:
FlyString const& custom_ident() const { return m_custom_ident; }
virtual String to_string(SerializationMode) const override { return m_custom_ident.to_string(); }
virtual Vector<Parser::ComponentValue> tokenize() const override
{
return { Parser::Token::create_ident(m_custom_ident) };
}
bool properties_equal(CustomIdentStyleValue const& other) const { return m_custom_ident == other.m_custom_ident; }