mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-04 15:19:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/CSS: Add tokenize() method to style values, to get a list of CVs

Browse source 
A couple of arbitrary substitution functions require us to get or
produce some style value, and then substitute its ComponentValues into
the original ComponentValue list. So this commit gives CSSStyleValue a
tokenize() method that does so.

Apart from a couple of unusual cases like the guaranteed-invalid value,
style values can all be converted into ComponentValues by serializing
them as a string, and then parsing that as a list of component values.
That feels unnecessarily inefficient in most cases though, so I've
implemented faster overrides for a lot of the basic style value
classes, but left that serialize-and-reparse method as the fallback.
This commit is contained in:
Sam Atkins 2025-07-10 12:17:27 +01:00 • committed by Tim Ledbetter
commit 5aba457009
Notes: github-actions[bot] 2025-07-16 13:50:05 +00:00
17 changed files with 90 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/CSS/StyleValues/StyleValueList.cpp
View file

@ -8,6 +8,7 @@
*/
#include "StyleValueList.h"
#include <LibWeb/CSS/Parser/ComponentValue.h>
namespace Web::CSS {
@ -46,4 +47,22 @@ void StyleValueList::set_style_sheet(GC::Ptr<CSSStyleSheet> style_sheet)
const_cast<CSSStyleValue&>(*value).set_style_sheet(style_sheet);
}
Vector<Parser::ComponentValue> StyleValueList::tokenize() const
{
Vector<Parser::ComponentValue> component_values;
bool first = true;
for (auto const& value : m_properties.values) {
if (first) {
first = false;
} else {
if (m_properties.separator == Separator::Comma)
component_values.empend(Parser::Token::create(Parser::Token::Type::Comma));
component_values.empend(Parser::Token::create_whitespace(" "_string));
}
component_values.extend(value->tokenize());
}
return component_values;
}
}