mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/IDB: Use correct state to check for throw condition

Browse source
This commit is contained in:
stelar7 2025-04-25 09:14:25 +02:00 • committed by Tim Flynn
commit 5ae069a031
Notes: github-actions[bot] 2025-04-25 11:24:34 +00:00
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View file

@ -254,7 +254,7 @@ WebIDL::ExceptionOr<ErrorOr<GC::Ref<Key>>> convert_a_value_to_a_key(JS::Realm& r
// - If input is a buffer source type
if (input.is_object() && (is<JS::TypedArrayBase>(input.as_object()) || is<JS::ArrayBuffer>(input.as_object()) || is<JS::DataView>(input.as_object()))) {
// 1. If input is [detached] then return invalid.
// 1. If input is detached then return invalid.
if (WebIDL::is_buffer_source_detached(input))
return Error::from_string_literal("Detached buffer is not supported as key");
@ -399,14 +399,13 @@ GC::Ref<IDBTransaction> upgrade_a_database(JS::Realm& realm, GC::Ref<IDBDatabase
// 5. Let didThrow be the result of firing a version change event named upgradeneeded at request with old version and version.
auto did_throw = fire_a_version_change_event(realm, HTML::EventNames::upgradeneeded, request, old_version, version);
// AD-HOC: If the transaction was aborted by the event, then DONT set the transaction back to inactive.
// https://github.com/w3c/IndexedDB/issues/436#issuecomment-2791113467
if (transaction->state() != IDBTransaction::TransactionState::Finished) {
// 6. If transaction’s state is active, then:
if (transaction->state() == IDBTransaction::TransactionState::Active) {
// 6. Set transaction’s state to inactive.
// 1. Set transaction’s state to inactive.
transaction->set_state(IDBTransaction::TransactionState::Inactive);
// 7. If didThrow is true, run abort a transaction with transaction and a newly created "AbortError" DOMException.
// 2. If didThrow is true, run abort a transaction with transaction and a newly created "AbortError" DOMException.
if (did_throw)
abort_a_transaction(transaction, WebIDL::AbortError::create(realm, "Version change event threw an exception"_string));