mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-01 15:18:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Set dirty checkedness flag when setting checked IDL attribute

Browse source 
This matches the behavior of other browsers, which always set the dirty
checkedness flag when setting checkedness, except when setting the
`checked` content attribute.
This commit is contained in:
Tim Ledbetter 2025-01-05 20:50:09 +00:00 • committed by Andreas Kling
commit 5b6f2bb23a
Notes: github-actions[bot] 2025-01-11 10:25:26 +00:00
5 changed files with 180 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

64
Tests/LibWeb/Text/input/wpt-import/html/semantics/forms/the-input-element/cloning-steps.html Normal file
View file

@ -0,0 +1,64 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Cloning of input elements</title>
<link rel="help" href="https://dom.spec.whatwg.org/#dom-node-clonenode">
<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone">
<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone-ext">
<link rel="help" href="https://html.spec.whatwg.org/multipage/forms.html#the-input-element:concept-node-clone-ext">
<link rel="author" title="Matthew Phillips" href="mailto:matthew@matthewphillips.info">
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<script type=module>
import inputTypes from "./input-types.js";
test(function() {
var input = document.createElement("input");
input.value = "foo bar";
var copy = input.cloneNode();
assert_equals(copy.value, "foo bar");
}, "input element's value should be cloned");
test(function() {
var input = document.createElement("input");
input.value = "foo bar";
var copy = input.cloneNode();
copy.setAttribute("value", "something else");
assert_equals(copy.value, "foo bar");
}, "input element's dirty value flag should be cloned, so setAttribute doesn't affect the cloned input's value");
for (const inputType of inputTypes) {
test(function() {
var input = document.createElement("input");
input.setAttribute("type", inputType);
input.indeterminate = true;
var copy = input.cloneNode();
assert_equals(copy.indeterminate, true);
}, `input[type=${inputType}] element's indeterminateness should be cloned`);
test(function() {
var input = document.createElement("input");
input.setAttribute("type", inputType);
input.checked = true;
var copy = input.cloneNode();
assert_equals(copy.checked, true);
}, `input[type=${inputType}] element's checkedness should be cloned`);
test(function() {
var input = document.createElement("input");
input.setAttribute("type", inputType);
input.checked = false;
var copy = input.cloneNode();
copy.setAttribute("checked", "checked");
assert_equals(copy.checked, false);
}, `input[type=${inputType}] element's dirty checkedness should be cloned, so setAttribute doesn't affect the cloned input's checkedness`);
}
</script>

24
Tests/LibWeb/Text/input/wpt-import/html/semantics/forms/the-input-element/input-types.js Normal file
View file

@ -0,0 +1,24 @@
export default [
"button",
"checkbox",
"color",
"date",
"datetime-local",
"email",
"file",
"hidden",
"image",
"month",
"number",
"password",
"radio",
"range",
"reset",
"search",
"submit",
"tel",
"text",
"time",
"url",
"week",
];