mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Iterate safely in HTMLSelectElement::set_value()

Browse source 
We can't iterate over m_cached_list_of_options and call set_selected()
in the loop, since that may end up rebuilding m_cached_list_of_options,
disrupting iteration.
This commit is contained in:
Andreas Kling 2025-05-28 11:25:20 +02:00 • committed by Alexander Kalenik
commit 5c5283492b
Notes: github-actions[bot] 2025-05-29 01:48:10 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -377,7 +377,7 @@ String HTMLSelectElement::value() const
WebIDL::ExceptionOr<void> HTMLSelectElement::set_value(String const& value) WebIDL::ExceptionOr<void> HTMLSelectElement::set_value(String const& value)
{ {
update_cached_list_of_options(); update_cached_list_of_options();
for (auto const& option_element : m_cached_list_of_options) for (auto const& option_element : list_of_options())
option_element->set_selected(option_element->value() == value); option_element->set_selected(option_element->value() == value);
update_inner_text_element(); update_inner_text_element();
return {}; return {};