From 5d00211a8605b0fab9f330082699f6f089961052 Mon Sep 17 00:00:00 2001
From: Arhcout <coutearnouxj@gmail.com>
Date: Wed, 25 Sep 2024 10:56:02 +0200
Subject: [PATCH] LibWeb: Don't trigger onchange event when setting <select>
 value

---
 ...tElement-value-change-trigger-onchange.txt |  1 +
 ...Element-value-change-trigger-onchange.html | 26 +++++++++++++++++++
 .../LibWeb/HTML/HTMLSelectElement.cpp         |  1 -
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt
 create mode 100644 Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html
diff --git a/Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt b/Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt
new file mode 100644
index 00000000000..5df6241a8b5
--- /dev/null
+++ b/Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt
@@ -0,0 +1 @@
+  PASS
diff --git a/Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html b/Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html
new file mode 100644
index 00000000000..756d0f0878d
--- /dev/null
+++ b/Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<script src="../include.js"></script>
+<select id="select-test">
+    <option value="A"></option>
+    <option value="B"></option>
+</select>
+<script>
+    asyncTest(done => {
+        const selectElement = document.getElementById("select-test");
+        let onchangeTriggered = false;
+        
+        selectElement.onchange = () => {
+            onchangeTriggered = true;
+        }
+        
+        selectElement.value = "B";
+        setTimeout(() => {
+            if (!onchangeTriggered) {
+                println("PASS");
+            } else {
+                println("FAILED");
+            }
+            done();
+        }, 1);
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
index 14c0a2c1273..1fb9a1d6663 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
+++ b/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
@@ -295,7 +295,6 @@ WebIDL::ExceptionOr<void> HTMLSelectElement::set_value(String const& value)
     for (auto const& option_element : list_of_options())
         option_element->set_selected(option_element->value() == value);
     update_inner_text_element();
-    queue_input_and_change_events();
     return {};
 }
 
