mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-01 08:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Return DOMException instead of crashing when setting attributes

Browse source
This commit is contained in:
PrestonLTaylor 2023-05-25 20:37:57 +01:00 • committed by Andreas Kling
parent 6891676fce
commit 5d3b7a5ecc
Notes: sideshowbarker 2024-07-16 19:42:24 +09:00
24 changed files with 57 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/HTMLTableElement.cpp
View file

@ -72,14 +72,16 @@ JS::GCPtr<HTMLTableCaptionElement> HTMLTableElement::caption()
}
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-caption
void HTMLTableElement::set_caption(HTMLTableCaptionElement* caption)
WebIDL::ExceptionOr<void> HTMLTableElement::set_caption(HTMLTableCaptionElement* caption)
{
// On setting, the first caption element child of the table element, if any, must be removed,
// and the new value, if not null, must be inserted as the first node of the table element.
delete_caption();
if (caption)
MUST(pre_insert(*caption, first_child()));
TRY(pre_insert(*caption, first_child()));
return {};
}
// https://html.spec.whatwg.org/multipage/tables.html#dom-table-createcaption