mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 12:35:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Minor code cleanup; use HTML::AttributeNames::value, not string

Browse source 
This is a minor change to the Node::name_or_description code to switch
some instances of element.has_attribute("value"_string) over to instead
using element.has_attribute(HTML::AttributeNames::value).
This commit is contained in:
sideshowbarker 2024-12-04 19:06:47 +09:00 • committed by Tim Flynn
parent db87f173fb
commit 5d47ba1e38
Notes: github-actions[bot] 2024-12-05 13:05:58 +00:00
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/DOM/Node.cpp
View file

@ -2343,7 +2343,7 @@ ErrorOr<String> Node::name_or_description(NameOrDescription target, Document con
// i. Textbox: If the embedded control has role textbox, return its value.
if (is<HTML::HTMLInputElement>(*node)) {
auto const& element = static_cast<HTML::HTMLInputElement const&>(*node);
if (element.has_attribute("value"_string))
if (element.has_attribute(HTML::AttributeNames::value))
builder.append(element.value());
} else
builder.append(node->text_content().value());
@ -2351,7 +2351,7 @@ ErrorOr<String> Node::name_or_description(NameOrDescription target, Document con
// ii. Combobox/Listbox: If the embedded control has role combobox or listbox, return the text alternative of the chosen option.
if (is<HTML::HTMLInputElement>(*node)) {
auto const& element = static_cast<HTML::HTMLInputElement const&>(*node);
if (element.has_attribute("value"_string))
if (element.has_attribute(HTML::AttributeNames::value))
builder.append(element.value());
} else if (is<HTML::HTMLSelectElement>(*node)) {
auto const& element = static_cast<HTML::HTMLSelectElement const&>(*node);
@ -2384,7 +2384,7 @@ ErrorOr<String> Node::name_or_description(NameOrDescription target, Document con
// c. Otherwise, use the value as specified by a host language attribute.
else if (is<HTML::HTMLInputElement>(*node)) {
auto const& element = static_cast<HTML::HTMLInputElement const&>(*node);
if (element.has_attribute("value"_string))
if (element.has_attribute(HTML::AttributeNames::value))
builder.append(element.value());
}
}