mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-01 07:52:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Handle <input> element type changing to the image button state

Browse source 
The spec has special steps specific to the image button state to load
the element's image URL.
This commit is contained in:
Timothy Flynn 2024-04-04 12:56:37 -04:00 • committed by Andreas Kling
parent 0e774fe780
commit 5d5b69578f
Notes: sideshowbarker 2024-07-16 19:42:24 +09:00
6 changed files with 61 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -1085,6 +1085,15 @@ void HTMLInputElement::form_associated_element_attribute_changed(FlyString const
set_shadow_root(nullptr);
create_shadow_tree_if_needed();
// https://html.spec.whatwg.org/multipage/input.html#image-button-state-(type=image):the-input-element-4
// the input element's type attribute is changed back to the Image Button state, and the src attribute is present,
// and its value has changed since the last time the type attribute was in the Image Button state
if (type_state() == TypeAttributeState::ImageButton) {
if (auto src = attribute(AttributeNames::src); src.has_value() && src != m_last_src_value)
handle_src_attribute(*src).release_value_but_fixme_should_propagate_errors();
}
} else if (name == HTML::AttributeNames::value) {
if (!m_dirty_value) {
if (!value.has_value()) {
@ -1115,7 +1124,7 @@ void HTMLInputElement::form_associated_element_attribute_changed(FlyString const
}
// https://html.spec.whatwg.org/multipage/input.html#attr-input-src
WebIDL::ExceptionOr<void> HTMLInputElement::handle_src_attribute(StringView value)
WebIDL::ExceptionOr<void> HTMLInputElement::handle_src_attribute(String const& value)
{
auto& realm = this->realm();
auto& vm = realm.vm();
@ -1123,6 +1132,8 @@ WebIDL::ExceptionOr<void> HTMLInputElement::handle_src_attribute(StringView valu
if (type_state() != TypeAttributeState::ImageButton)
return {};
m_last_src_value = value;
// 1. Let url be the result of encoding-parsing a URL given the src attribute's value, relative to the element's
// node document.
auto url = document().parse_url(value);