mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 04:39:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Do not give the HTML namespace to elements when parsing XML

Browse source 
While the code that did this referred to the HTML spec, other browsers
appear not to have this behavior when parsing XML, and it breaks a WPT
subtest.

This change does not appear to break any tests, and fixes 1 WPT subtest.
This commit is contained in:
Milo van der Tier 2024-11-25 21:34:29 +01:00 • committed by Ali Mohammad Pur
commit 5deb2b4cad
Notes: github-actions[bot] 2024-11-27 16:11:27 +00:00
3 changed files with 272 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/XML/XMLDocumentBuilder.cpp
View file

@ -92,27 +92,13 @@ void XMLDocumentBuilder::element_start(const XML::Name& name, HashMap<XML::Name,
if (m_has_error)
return;
auto found_explicit_namespace = false;
if (auto it = attributes.find("xmlns"); it != attributes.end()) {
found_explicit_namespace = true;
m_namespace_stack.append({ m_namespace, 1 });
m_namespace = MUST(FlyString::from_deprecated_fly_string(it->value));
} else {
m_namespace_stack.last().depth += 1;
}
if (name == HTML::TagNames::html.to_deprecated_fly_string() && m_namespace != Namespace::HTML) {
// HTML / 2.1.3 XML compatibility: https://html.spec.whatwg.org/#xml
// To ease migration from HTML to XML, user agents conforming to this specification will place elements in HTML
// in the http://www.w3.org/1999/xhtml namespace, at least for the purposes of the DOM and CSS.
// The term "HTML elements" refers to any element in that namespace, even in XML documents.
if (found_explicit_namespace || m_namespace_stack.size() != 1 || m_namespace_stack.last().depth != 2) {
m_has_error = true;
return;
}
m_namespace = Namespace::HTML;
}
auto node = DOM::create_element(m_document, MUST(FlyString::from_deprecated_fly_string(name)), m_namespace).release_value_but_fixme_should_propagate_errors();
// When an XML parser with XML scripting support enabled creates a script element,