mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-10 05:02:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

GEventLoop: Don't call process_unprocessed_messages() from itself.

Browse source 
This could be tail-call-optimized but it's not, so we end up overflowing the
stack space if we recurse too many times. This was causing crashes when
resizing Minesweeper.
This commit is contained in:
Andreas Kling 2019-04-28 22:03:18 +02:00
parent c91b0d6b5f
commit 5dee5c325e
Notes: sideshowbarker 2024-07-19 14:33:39 +09:00
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
LibGUI/GEventLoop.cpp
View file

@ -316,9 +316,6 @@ void GEventLoop::process_unprocessed_bundles()
if (coalesced_resizes)
dbgprintf("Coalesced %d resizes\n", coalesced_resizes);
#endif
if (!m_unprocessed_bundles.is_empty())
process_unprocessed_bundles();
}
bool GEventLoop::drain_messages_from_server()

1
LibGUI/GEventLoop.h
View file

@ -43,6 +43,7 @@ private:
virtual void do_processing() override
{
while (!m_unprocessed_bundles.is_empty())
process_unprocessed_bundles();
}