mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-28 19:59:17 +00:00
LibWeb: Support unbuffered fetch requests
Supporting unbuffered fetches is actually part of the fetch spec in its HTTP-network-fetch algorithm. We had previously implemented this method in a very ad-hoc manner as a simple wrapper around ResourceLoader. This is still the case, but we now implement a good amount of these steps according to spec, using ResourceLoader's unbuffered API. The response data is forwarded through to the fetch response using streams. This will eventually let us remove the use of ResourceLoader's buffered API, as all responses should just be streamed this way. The streams spec then supplies ways to wait for completion, thus allowing fully buffered responses. However, we have more work to do to make the other parts of our fetch implementation (namely, Body::fully_read) use streams before we can do this.
This commit is contained in:
parent
1e97ae66e5
commit
6056428cb5
Notes:
sideshowbarker
2024-07-18 05:01:22 +09:00
Author: https://github.com/trflynn89
Commit: 6056428cb5
Pull-request: https://github.com/SerenityOS/serenity/pull/24452
Issue: https://github.com/SerenityOS/serenity/issues/23847
8 changed files with 266 additions and 8 deletions
|
@ -159,6 +159,13 @@ public:
|
|||
Auto
|
||||
};
|
||||
|
||||
// AD-HOC: Some web features need to receive data as it arrives, rather than when the response is fully complete
|
||||
// or when enough data has been buffered. Use this buffer policy to inform fetch of that requirement.
|
||||
enum class BufferPolicy {
|
||||
BufferResponse,
|
||||
DoNotBufferResponse,
|
||||
};
|
||||
|
||||
// Members are implementation-defined
|
||||
struct InternalPriority { };
|
||||
|
||||
|
@ -325,6 +332,9 @@ public:
|
|||
m_pending_responses.remove_first_matching([&](auto gc_ptr) { return gc_ptr == pending_response; });
|
||||
}
|
||||
|
||||
[[nodiscard]] BufferPolicy buffer_policy() const { return m_buffer_policy; }
|
||||
void set_buffer_policy(BufferPolicy buffer_policy) { m_buffer_policy = buffer_policy; }
|
||||
|
||||
private:
|
||||
explicit Request(JS::NonnullGCPtr<HeaderList>);
|
||||
|
||||
|
@ -515,6 +525,8 @@ private:
|
|||
|
||||
// Non-standard
|
||||
Vector<JS::NonnullGCPtr<Fetching::PendingResponse>> m_pending_responses;
|
||||
|
||||
BufferPolicy m_buffer_policy { BufferPolicy::BufferResponse };
|
||||
};
|
||||
|
||||
StringView request_destination_to_string(Request::Destination);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue