mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix endless spinning in apply_the_history_step()

Browse source 
While waiting for a task that populates a session history entry, we
can't limit the processing of the event loop to the
`NavigationAndTraversal` task source. This is because fetching uses the
`Networking` task source, which also needs to be processed.

Since making a fetch request might take some time, we want to process
everything on the event loop while waiting, to avoid blocking user
interactions.

It is still possible to use `spin_processing_tasks_with_source_until()`
on subsequent steps of `apply_the_history_step()`.

Also modifies test that was flaky.
This commit is contained in:
Aliaksandr Kalenik 2024-03-25 19:08:27 +01:00 • committed by Andreas Kling
commit 609a72f7c7
Notes: sideshowbarker 2024-07-18 05:01:22 +09:00
3 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Tests/LibWeb/Text/input/navigation/remove-iframe-from-timeout-callback.html
View file

@ -1,12 +1,16 @@
<script src="../include.js"></script>
<div id="foo">
<iframe></iframe>
<script>
setTimeout(function () {
foo.remove();
// Pass (didn't crash)
internals.signalTextTestIsDone();
<script src="../include.js"></script><div id="foo"><iframe></iframe><script>
setTimeout(function () {
foo.remove();
window.done = true;
}, 0);
</script></div><iframe></iframe><script>
asyncTest(function (done) {
let internalId;
internalId = setInterval(function () {
if (window.done) {
clearInterval(internalId);
done();
}
}, 0);
</script>
</div>
<iframe></iframe>
});
</script>PASS: did not crash