mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-10 01:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix inside list style overriding content offset

Browse source 
Previously, if a horizontal margin was set on a list-item and
it was list-style-position: inside, it would effectively remove
that margin.
This commit is contained in:
Oliver Medhurst 2025-03-27 22:34:27 +00:00 • committed by Andreas Kling
commit 60fd406903
Notes: github-actions[bot] 2025-03-27 23:11:11 +00:00
3 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -1233,7 +1233,7 @@ void BlockFormattingContext::layout_list_item_marker(ListItemBox const& list_ite
auto final_marker_width = marker_state.content_width() + default_marker_width;
if (marker.list_style_position() == CSS::ListStylePosition::Inside) {
list_item_state.set_content_offset({ final_marker_width, list_item_state.offset.y() });
list_item_state.set_content_x(list_item_state.offset.x() + final_marker_width);
list_item_state.set_content_width(list_item_state.content_width() - final_marker_width);
}

14
Tests/LibWeb/Layout/expected/inside-list-item-content-offset.txt Normal file
View file

@ -0,0 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x417 [BFC] children: not-inline
BlockContainer <body> at (8,200) content-size 784x17 children: not-inline
ListItemBox <span> at (232,200) content-size 360x17 children: not-inline
ListItemMarkerBox <(anonymous)> at (208,200) content-size 12x17 children: not-inline
BlockContainer <(anonymous)> at (8,400) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x417]
PaintableWithLines (BlockContainer<BODY>) [8,200 784x17]
PaintableWithLines (ListItemBox<SPAN>) [232,200 360x17] overflow: [208,200 384x17]
MarkerPaintable (ListItemMarkerBox(anonymous)) [208,200 12x17]
PaintableWithLines (BlockContainer(anonymous)) [8,400 784x0]

10
Tests/LibWeb/Layout/input/inside-list-item-content-offset.html Normal file
View file

@ -0,0 +1,10 @@
<!DOCTYPE html>
<style>
span {
display: list-item;
list-style-position: inside;
margin: 200px;
}
</style>
<span></span>