mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibRegex: Ensure nullable quantifiers backtrack when input remains

Browse source 
Makes patterns like `/(a?b??)*/` correctly match the string
This commit is contained in:
aplefull 2025-03-01 18:23:15 +01:00 • committed by Ali Mohammad Pur
parent 40c71ff3c0
commit 61744322ad
Notes: github-actions[bot] 2025-03-02 14:20:04 +00:00
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibRegex/RegexByteCode.cpp
View file

@ -1118,6 +1118,10 @@ ALWAYS_INLINE ExecutionResult OpCode_JumpNonEmpty::execute(MatchInput const& inp
}
}
if (state.string_position < input.view.length()) {
return ExecutionResult::Failed_ExecuteLowPrioForks;
}
return ExecutionResult::Continue;
}

9
Tests/LibRegex/Regex.cpp
View file

@ -986,6 +986,15 @@ TEST_CASE(extremely_long_fork_chain)
EXPECT_EQ(result.success, true);
}
TEST_CASE(nullable_quantifiers)
{
// clang-format off
Regex<ECMA262> re("(a?b?""?)*"); // Pattern (a?b??)* has to be concatenated to avoid "??)", which is a trigraph.
// clang-format on
auto result = re.match("ab"sv);
EXPECT_EQ(result.matches.at(0).view, "ab"sv);
}
TEST_CASE(theoretically_infinite_loop)
{
Array patterns {