mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 05:39:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Reset a vector of contained abspos before collecting them again

Browse source 
Fixes a bug when a vector with contained absolutely positioned boxes
keeps growing, resulting in more duplicated work on each subsequent
layout.
This commit is contained in:
Aliaksandr Kalenik 2024-09-13 16:35:31 +02:00 • committed by Andreas Kling
commit 6199870528
Notes: github-actions[bot] 2024-09-13 14:49:41 +00:00
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1132,6 +1132,10 @@ void Document::update_layout()
} }
// Assign each box that establishes a formatting context a list of absolutely positioned children it should take care of during layout // Assign each box that establishes a formatting context a list of absolutely positioned children it should take care of during layout
m_layout_root->for_each_in_inclusive_subtree_of_type<Layout::Box>([&](auto& child) {
child.clear_contained_abspos_children();
return TraversalDecision::Continue;
});
m_layout_root->for_each_in_inclusive_subtree([&](auto& child) { m_layout_root->for_each_in_inclusive_subtree([&](auto& child) {
if (!child.is_absolutely_positioned()) if (!child.is_absolutely_positioned())
return TraversalDecision::Continue; return TraversalDecision::Continue;

1
Userland/Libraries/LibWeb/Layout/Box.h
View file

@ -55,6 +55,7 @@ public:
bool is_user_scrollable() const; bool is_user_scrollable() const;
void add_contained_abspos_child(JS::NonnullGCPtr<Node> child) { m_contained_abspos_children.append(child); } void add_contained_abspos_child(JS::NonnullGCPtr<Node> child) { m_contained_abspos_children.append(child); }
void clear_contained_abspos_children() { m_contained_abspos_children.clear(); }
Vector<JS::NonnullGCPtr<Node>> const& contained_abspos_children() const { return m_contained_abspos_children; } Vector<JS::NonnullGCPtr<Node>> const& contained_abspos_children() const { return m_contained_abspos_children; }
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;