mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-31 22:56:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Limit HTMLSelectElement.size to allowed values

Browse source 
This change ensures that the correct default value of 0 is used and
that values greater than 2147483647 will fall back to the default value.

It also splits the display size concept into a separate method, as
this isn't supposed to be used when getting the IDL property.
This commit is contained in:
Tim Ledbetter 2024-11-29 11:19:31 +00:00 • committed by Andreas Kling
commit 6218f1a609
Notes: github-actions[bot] 2024-11-29 12:39:58 +00:00
5 changed files with 41 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Tests/LibWeb/Text/expected/HTML/unsigned-long-reflection.txt
View file

@ -77,6 +77,26 @@ marquee.getAttribute("scrolldelay") after marquee.setAttribute("scrollDelay", "4
marquee.scrollDelay after marquee.setAttribute("scrolldelay", "4294967295"): 85
marquee.getAttribute("scrolldelay") after marquee.scrollDelay = 4294967295: 85
marquee.scrollDelay after marquee.scrollDelay = 4294967295: 85
select.getAttribute("size") after select.setAttribute("size", "0"): 0
select.size after select.setAttribute("size", "0"): 0
select.getAttribute("size") after select.size = 0: 0
select.size after select.size = 0: 0
select.getAttribute("size") after select.setAttribute("size", "1"): 1
select.size after select.setAttribute("size", "1"): 1
select.getAttribute("size") after select.size = 1: 1
select.size after select.size = 1: 1
select.getAttribute("size") after select.setAttribute("size", "2147483647"): 2147483647
select.size after select.setAttribute("size", "2147483647"): 2147483647
select.getAttribute("size") after select.size = 2147483647: 2147483647
select.size after select.size = 2147483647: 2147483647
select.getAttribute("size") after select.setAttribute("size", "2147483648"): 2147483648
select.size after select.setAttribute("size", "2147483648"): 0
select.getAttribute("size") after select.size = 2147483648: 0
select.size after select.size = 2147483648: 0
select.getAttribute("size") after select.setAttribute("size", "4294967295"): 4294967295
select.size after select.setAttribute("size", "4294967295"): 0
select.getAttribute("size") after select.size = 4294967295: 0
select.size after select.size = 4294967295: 0
textarea.getAttribute("rows") after textarea.setAttribute("rows", "0"): 0
textarea.rows after textarea.setAttribute("rows", "0"): 2
textarea.getAttribute("rows") after textarea.rows = 0: 2
@ -116,4 +136,4 @@ textarea.cols after textarea.cols = 2147483648: 20
textarea.getAttribute("cols") after textarea.setAttribute("cols", "4294967295"): 4294967295
textarea.cols after textarea.setAttribute("cols", "4294967295"): 20
textarea.getAttribute("cols") after textarea.cols = 4294967295: 20
textarea.cols after textarea.cols = 4294967295: 20
textarea.cols after textarea.cols = 4294967295: 20