From 627eb90086c70b150ab5a4acbd2d906657962cca Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 2 Nov 2024 11:19:55 -0400 Subject: [PATCH] LibWeb: Update WebDriver's list of collection types HTMLAllCollection and HTMLFormControlsCollection were implemented since this AO was written, and DOMTokenList was added to the spec. --- Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp index c9d7726d818..c88cf279414 100644 --- a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp +++ b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp @@ -19,11 +19,14 @@ #include #include #include +#include #include #include #include #include #include +#include +#include #include #include #include @@ -60,14 +63,16 @@ static bool is_collection(JS::Object const& value) value.has_parameter_map() // - instance of Array || is(value) + // - instance of DOMTokenList + || is(value) // - instance of FileList || is(value) // - instance of HTMLAllCollection - || false // FIXME + || is(value) // - instance of HTMLCollection || is(value) // - instance of HTMLFormControlsCollection - || false // FIXME + || is(value) // - instance of HTMLOptionsCollection || is(value) // - instance of NodeList