mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-25 18:58:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibDSP: Fix keyboard glitch in Classic

Browse source 
This is quite elusive.
This commit is contained in:
kleines Filmröllchen 2022-05-14 01:26:22 +02:00 • committed by Linus Groh
commit 62c1ce4073
Notes: sideshowbarker 2024-07-17 11:06:06 +09:00
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibDSP/Synthesizers.cpp
View file

@ -51,10 +51,22 @@ void Classic::process_impl(Signal const& input_signal, [[maybe_unused]] Signal&
if (m_playing_notes.contains(i)) { if (m_playing_notes.contains(i)) {
Envelope note_envelope = m_playing_notes.get(i)->to_envelope(sample_time, m_attack * m_transport->ms_sample_rate(), m_decay * m_transport->ms_sample_rate(), m_release * m_transport->ms_sample_rate()); Envelope note_envelope = m_playing_notes.get(i)->to_envelope(sample_time, m_attack * m_transport->ms_sample_rate(), m_decay * m_transport->ms_sample_rate(), m_release * m_transport->ms_sample_rate());
// There are two conditions for removing notes:
// 1. The envelope has expired, regardless of whether the note was still given to us in the input.
if (!note_envelope.is_active()) { if (!note_envelope.is_active()) {
m_playing_notes.remove(i); m_playing_notes.remove(i);
continue; continue;
} }
// 2. The envelope has not expired, but the note was not given to us.
// This means that the note abruptly stopped playing; i.e. the audio infrastructure didn't know the length of the notes initially.
// That basically means we're dealing with a keyboard note. Chop its end time to end now.
if (!note_envelope.is_release() && !in.get(i).has_value()) {
// dbgln("note {} not released, setting release phase, envelope={}", i, note_envelope.envelope);
note_envelope.set_release(0);
auto real_note = *m_playing_notes.get(i);
real_note.off_sample = sample_time;
m_playing_notes.set(i, real_note);
}
playing_envelopes.append(PitchedEnvelope { note_envelope, i }); playing_envelopes.append(PitchedEnvelope { note_envelope, i });
} }