mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-26 12:17:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Report exceptions that occur during microtask callback

Browse source
This commit is contained in:
Tim Ledbetter 2024-12-05 10:05:10 +00:00 • committed by Tim Ledbetter
commit 62ecff0b40
Notes: github-actions[bot] 2024-12-19 15:26:16 +00:00
6 changed files with 74 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/HTMLCanvasElement.cpp
View file

@ -375,8 +375,8 @@ WebIDL::ExceptionOr<void> HTMLCanvasElement::to_blob(GC::Ref<WebIDL::CallbackTyp
if (file_result.has_value())
blob_result = FileAPI::Blob::create(realm(), file_result->buffer, TRY_OR_THROW_OOM(vm(), String::from_utf8(file_result->mime_type)));
// 2. Invoke callback with « result ».
TRY(WebIDL::invoke_callback(*callback, {}, move(blob_result)));
// 2. Invoke callback with « result » and "report".
TRY(WebIDL::invoke_callback(*callback, {}, WebIDL::ExceptionBehavior::Report, move(blob_result)));
return {};
});
if (maybe_error.is_throw_completion())

8
Libraries/LibWeb/HTML/UniversalGlobalScope.cpp
View file

@ -84,11 +84,9 @@ void UniversalGlobalScopeMixin::queue_microtask(WebIDL::CallbackType& callback)
if (is<Window>(this_impl()))
document = &static_cast<Window&>(this_impl()).associated_document();
// The queueMicrotask(callback) method must queue a microtask to invoke callback, and if callback throws an exception, report the exception.
HTML::queue_a_microtask(document, GC::create_function(realm.heap(), [&callback, &realm] {
auto result = WebIDL::invoke_callback(callback, {});
if (result.is_error())
HTML::report_exception(result, realm);
// The queueMicrotask(callback) method must queue a microtask to invoke callback with « » and "report".
HTML::queue_a_microtask(document, GC::create_function(realm.heap(), [&callback] {
(void)WebIDL::invoke_callback(callback, {}, WebIDL::ExceptionBehavior::Report);
}));
}