mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix dialog.requestClose() crash

Browse source 
The spec previously asserted that close watcher was not null.

This could lead to a crash in some situations,
so instead we skip to close the dialog.
This commit is contained in:
Luke Warlow 2025-02-02 23:59:01 +00:00 • committed by Andreas Kling
parent 6147557999
commit 62f4cebbee
Notes: github-actions[bot] 2025-02-04 11:23:18 +00:00
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/HTML/HTMLDialogElement.cpp
View file

@ -242,8 +242,11 @@ void HTMLDialogElement::request_close(Optional<String> return_value)
// 1. If this does not have an open attribute, then return.
if (!has_attribute(AttributeNames::open))
return;
// 2. Assert: this's close watcher is not null.
VERIFY(m_close_watcher);
// ADHOC: 2. If this's close watcher is null, then close the dialog this with returnValue, and return. See https://github.com/whatwg/html/pull/10983
if (!m_close_watcher) {
close_the_dialog(move(return_value));
return;
}
// 3. Set dialog's enable close watcher for requestClose() to true.
// ADHOC: Implemented slightly differently to the spec, as the spec is unnecessarily complex.
m_close_watcher->set_enabled(true);

11
Tests/LibWeb/Crash/wpt-import/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose-crash.html Normal file
View file

@ -0,0 +1,11 @@
<!DOCTYPE html>
<!-- This test passes if it does not crash. -->
<dialog id="dialog" open>Dialog</dialog>
<script>
window.onload = () => {
dialog.requestClose();
}
</script>