mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 09:39:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Support appending files to <input type=file>

Browse source 
This isn't exposed to the Web, but WebDriver requires this feature.
This commit is contained in:
Timothy Flynn 2024-10-10 20:10:37 -04:00 • committed by Andreas Kling
commit 63b24e38fa
Notes: github-actions[bot] 2024-10-11 07:10:23 +00:00
2 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -469,7 +469,7 @@ void HTMLInputElement::did_pick_color(Optional<Color> picked_color, ColorPickerU
} }
} }
void HTMLInputElement::did_select_files(Span<SelectedFile> selected_files) void HTMLInputElement::did_select_files(Span<SelectedFile> selected_files, MultipleHandling multiple_handling)
{ {
// https://html.spec.whatwg.org/multipage/input.html#show-the-picker,-if-applicable // https://html.spec.whatwg.org/multipage/input.html#show-the-picker,-if-applicable
// 4. If the user dismissed the prompt without changing their selection, then queue an element task on the user // 4. If the user dismissed the prompt without changing their selection, then queue an element task on the user
@ -504,9 +504,17 @@ void HTMLInputElement::did_select_files(Span<SelectedFile> selected_files)
// https://html.spec.whatwg.org/multipage/input.html#update-the-file-selection // https://html.spec.whatwg.org/multipage/input.html#update-the-file-selection
// 1. Queue an element task on the user interaction task source given element and the following steps: // 1. Queue an element task on the user interaction task source given element and the following steps:
queue_an_element_task(HTML::Task::Source::UserInteraction, [this, files]() mutable { queue_an_element_task(HTML::Task::Source::UserInteraction, [this, files, multiple_handling]() mutable {
auto multiple = has_attribute(HTML::AttributeNames::multiple);
// 1. Update element's selected files so that it represents the user's selection. // 1. Update element's selected files so that it represents the user's selection.
if (m_selected_files && multiple && multiple_handling == MultipleHandling::Append) {
for (size_t i = 0; i < files->length(); ++i)
m_selected_files->add_file(*files->item(i));
} else {
m_selected_files = files; m_selected_files = files;
}
update_file_input_shadow_tree(); update_file_input_shadow_tree();
// 2. Fire an event named input at the input element, with the bubbles and composed attributes initialized to true. // 2. Fire an event named input at the input element, with the bubbles and composed attributes initialized to true.

6
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -105,7 +105,11 @@ public:
void did_pick_color(Optional<Color> picked_color, ColorPickerUpdateState state); void did_pick_color(Optional<Color> picked_color, ColorPickerUpdateState state);
void did_select_files(Span<SelectedFile> selected_files); enum class MultipleHandling {
Replace,
Append,
};
void did_select_files(Span<SelectedFile> selected_files, MultipleHandling = MultipleHandling::Replace);
JS::GCPtr<FileAPI::FileList> files(); JS::GCPtr<FileAPI::FileList> files();
void set_files(JS::GCPtr<FileAPI::FileList>); void set_files(JS::GCPtr<FileAPI::FileList>);