mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-24 19:28:48 +00:00
LibJS: Skip "return" method call while closing built-in iterators
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
"return" method is not defined on any of builtin iterators, so we could skip it, avoiding method lookup. I measured 10% improvement in array-destructuring-assignment.js micro benchmark with this change.
This commit is contained in:
parent
6d2f393f2b
commit
6426586052
Notes:
github-actions[bot]
2025-05-01 16:18:01 +00:00
Author: https://github.com/kalenikaliaksandr
Commit: 6426586052
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4546
1 changed files with 4 additions and 0 deletions
|
@ -271,6 +271,10 @@ static Completion iterator_close_impl(VM& vm, IteratorRecord const& iterator_rec
|
||||||
// 2. Let iterator be iteratorRecord.[[Iterator]].
|
// 2. Let iterator be iteratorRecord.[[Iterator]].
|
||||||
auto iterator = iterator_record.iterator;
|
auto iterator = iterator_record.iterator;
|
||||||
|
|
||||||
|
// OPTIMIZATION: "return" method is not defined on any of iterators we treat as built-in.
|
||||||
|
if (iterator->as_builtin_iterator())
|
||||||
|
return completion;
|
||||||
|
|
||||||
// 3. Let innerResult be Completion(GetMethod(iterator, "return")).
|
// 3. Let innerResult be Completion(GetMethod(iterator, "return")).
|
||||||
auto inner_result = ThrowCompletionOr<Value> { js_undefined() };
|
auto inner_result = ThrowCompletionOr<Value> { js_undefined() };
|
||||||
auto get_method_result = Value(iterator).get_method(vm, vm.names.return_);
|
auto get_method_result = Value(iterator).get_method(vm, vm.names.return_);
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue