mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-16 07:11:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb: Remove unnecessary full layout tree drop in SVGUseElement

Browse source 
This full invalidation was just papering over earlier bugs in the
partial layout tree update code. The DOM mutations that happen here
should be enough to drive the necessary invalidation now.

Note that this is covered by a regression test added with the
invalidation.
This commit is contained in:
Andreas Kling 2025-03-07 11:26:44 +01:00 • committed by Alexander Kalenik
parent 2abbf99a95
commit 6444fdf5ae
Notes: github-actions[bot] 2025-03-08 02:38:51 +00:00
2 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/SVG/SVGUseElement.cpp
View file

@ -183,9 +183,6 @@ void SVGUseElement::clone_element_tree_as_our_shadow_tree(Element* to_clone)
auto cloned_reference_node = MUST(to_clone->clone_node(nullptr, true));
shadow_root()->append_child(cloned_reference_node).release_value_but_fixme_should_propagate_errors();
}
// FIXME: Only invalidate the part of the layout tree that is affected by this change.
document().invalidate_layout_tree(DOM::InvalidateLayoutTreeReason::SVGUseElement);
}
bool SVGUseElement::is_valid_reference_element(Element const& reference_element) const