mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-01 23:26:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb: Check CanvasTextDrawingStyles.font assignment is valid

Browse source 
Checking that the string parsed for the `font` property is not enough,
the spec also wants to rule out CSS-wide keywords like `inherit`. The
simplest way to do so is to check if it's a ShorthandStyleValue, which
also rules out use of `var()`; this matches other browsers' behaviour.

The newly-added test would previously crash, and now doesn't. :^)
This commit is contained in:
Sam Atkins 2024-07-23 16:14:26 +01:00 • committed by Andreas Kling
commit 64d45afd8a
Notes: github-actions[bot] 2024-07-23 16:01:08 +00:00
3 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Text/input/canvas/invalid-font-property.html Normal file
View file

@ -0,0 +1,15 @@
<script src="../include.js"></script>
<script>
test(() => {
let canvas = document.createElement("canvas");
let context = canvas.getContext("2d");
context.font = '20px SerenitySans';
println(context.font);
context.font = 'inherit'; // CSS-wide keywords are not allowed
println(context.font);
context.font = 'var(--font-size, 30px) Arial'; // Variables are not allowed here
println(context.font);
context.font = '!!!'; // Invalid value, should be ignored.
println(context.font);
});
</script>