mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 05:39:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Save ScrollState snapshot in DisplayList to avoid race condition
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
With this change we save a copy of of scroll state at the time of
recording a display list, instead of actual ScrollState pointer that
could be modifed by the main thread while display list is beings
rasterized on the rendering thread, which leads to a frame painted with
inconsistent scroll state.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/4288
This commit is contained in:
Aliaksandr Kalenik 2025-04-11 20:00:56 +02:00 • committed by Alexander Kalenik
commit 6507d23e29
Notes: github-actions[bot] 2025-04-12 00:56:11 +00:00
18 changed files with 85 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Libraries/LibWeb/Painting/ScrollState.h
View file

@ -1,15 +1,42 @@
/*
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
* Copyright (c) 2024-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/NonnullOwnPtr.h>
#include <LibWeb/Painting/ScrollFrame.h>
namespace Web::Painting {
class ScrollStateSnapshot {
public:
static ScrollStateSnapshot create(Vector<NonnullRefPtr<ScrollFrame>> const& scroll_frames);
CSSPixelPoint cumulative_offset_for_frame_with_id(size_t id) const
{
if (id >= entries.size())
return {};
return entries[id].cumulative_offset;
}
CSSPixelPoint own_offset_for_frame_with_id(size_t id) const
{
if (id >= entries.size())
return {};
return entries[id].own_offset;
}
private:
struct Entry {
CSSPixelPoint cumulative_offset;
CSSPixelPoint own_offset;
};
Vector<Entry> entries;
};
class ScrollState {
public:
NonnullRefPtr<ScrollFrame> create_scroll_frame_for(PaintableBox const& paintable_box, RefPtr<ScrollFrame const> parent)
@ -56,6 +83,11 @@ public:
}
}
ScrollStateSnapshot snapshot() const
{
return ScrollStateSnapshot::create(m_scroll_frames);
}
private:
Vector<NonnullRefPtr<ScrollFrame>> m_scroll_frames;
};