mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 03:55:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Stop using MVL for sequence storage in WrapperGenerator

Browse source 
Use MarkedVector<Value> instead.
This commit is contained in:
Linus Groh 2022-02-09 10:08:48 +00:00
parent bc183dbbcb
commit 6508ff5bbd
Notes: sideshowbarker 2024-07-17 19:06:36 +09:00
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator.cpp
View file

@ -82,9 +82,8 @@ static size_t get_function_length(FunctionType& function)
}
enum class SequenceStorageType {
Vector, // Used to safely store non-JS values
MarkedValueList, // Used to safely store JS::Value
MarkedVector, // Used to safely store anything that inherits JS::Cell, e.g. JS::Object
Vector, // Used to safely store non-JS values
MarkedVector, // Used to safely store JS::Value and anything that inherits JS::Cell, e.g. JS::Object
};
struct CppType {
@ -954,8 +953,6 @@ static StringView sequence_storage_type_to_cpp_storage_type_name(SequenceStorage
switch (sequence_storage_type) {
case SequenceStorageType::Vector:
return "Vector"sv;
case SequenceStorageType::MarkedValueList:
return "JS::MarkedValueList"sv;
case SequenceStorageType::MarkedVector:
return "JS::MarkedVector"sv;
default:
@ -991,7 +988,7 @@ static CppType idl_type_name_to_cpp_type(Type const& type)
return { .name = "i32", .sequence_storage_type = SequenceStorageType::Vector };
if (type.name == "any")
return { .name = "JS::Value", .sequence_storage_type = SequenceStorageType::MarkedValueList };
return { .name = "JS::Value", .sequence_storage_type = SequenceStorageType::MarkedVector };
if (type.name == "sequence") {
auto& parameterized_type = verify_cast<ParameterizedType>(type);
@ -999,7 +996,7 @@ static CppType idl_type_name_to_cpp_type(Type const& type)
auto sequence_cpp_type = idl_type_name_to_cpp_type(sequence_type);
auto storage_type_name = sequence_storage_type_to_cpp_storage_type_name(sequence_cpp_type.sequence_storage_type);
if (sequence_cpp_type.sequence_storage_type == SequenceStorageType::MarkedValueList || sequence_cpp_type.sequence_storage_type == SequenceStorageType::MarkedVector)
if (sequence_cpp_type.sequence_storage_type == SequenceStorageType::MarkedVector)
return { .name = storage_type_name, .sequence_storage_type = SequenceStorageType::Vector };
return { .name = String::formatted("{}<{}>", storage_type_name, sequence_cpp_type.name), .sequence_storage_type = SequenceStorageType::Vector };