mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 22:30:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Shell: Don't do null check on NonnullRefPtr<T>

Browse source 
This will cause a problem when `NonnullRefPtr<T>::operator T*` will be
declared as RETURNS_NONNULL. Clang emits a warning for this pointless
null check, which breaks CI.
This commit is contained in:
Daniel Bertalan 2021-06-28 16:29:06 +02:00 • committed by Ali Mohammad Pur
commit 65b2d3add3
Notes: sideshowbarker 2024-07-18 11:19:30 +09:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Shell/AST.cpp
View file

@ -1775,7 +1775,7 @@ RefPtr<Value> IfCond::run(RefPtr<Shell> shell)
{ {
auto cond = m_condition->run(shell)->resolve_without_cast(shell); auto cond = m_condition->run(shell)->resolve_without_cast(shell);
// The condition could be a builtin, in which case it has already run and exited. // The condition could be a builtin, in which case it has already run and exited.
if (cond && cond->is_job()) { if (cond->is_job()) {
auto cond_job_value = static_cast<const JobValue*>(cond.ptr()); auto cond_job_value = static_cast<const JobValue*>(cond.ptr());
auto cond_job = cond_job_value->job(); auto cond_job = cond_job_value->job();