mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-18 23:12:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Set Document origin for DOMParser created documents

Browse source 
Previously, a crash would occur when accessing the origin of a document
created with DOMParser.
This commit is contained in:
Tim Ledbetter 2025-07-04 20:29:03 +01:00 • committed by Shannon Booth
parent 05ef650a59
commit 66ca4496c3
Notes: github-actions[bot] 2025-07-06 01:41:13 +00:00
3 changed files with 67 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/HTML/DOMParser.cpp
View file

@ -43,18 +43,18 @@ GC::Ref<DOM::Document> DOMParser::parse_from_string(StringView string, Bindings:
// 2. Let document be a new Document, whose content type is type and url is this's relevant global object's associated Document's URL.
GC::Ptr<DOM::Document> document;
auto& associated_document = as<HTML::Window>(relevant_global_object(*this)).associated_document();
// 3. Switch on type:
if (type == Bindings::DOMParserSupportedType::Text_Html) {
// -> "text/html"
document = HTML::HTMLDocument::create(realm(), as<HTML::Window>(relevant_global_object(*this)).associated_document().url());
document->set_content_type(Bindings::idl_enum_to_string(type));
document = HTML::HTMLDocument::create(realm(), associated_document.url());
// 1. Parse HTML from a string given document and compliantString. FIXME: Use compliantString.
document->parse_html_from_a_string(string);
} else {
// -> Otherwise
document = DOM::XMLDocument::create(realm(), as<HTML::Window>(relevant_global_object(*this)).associated_document().url());
document = DOM::XMLDocument::create(realm(), associated_document.url());
document->set_content_type(Bindings::idl_enum_to_string(type));
document->set_document_type(DOM::Document::Type::XML);
@ -76,6 +76,11 @@ GC::Ref<DOM::Document> DOMParser::parse_from_string(StringView string, Bindings:
}
}
// AD-HOC: Setting the origin to match that of the associated document matches the behavior of existing browsers
// and avoids a crash, since we expect the origin to always be set.
// Spec issue: https://github.com/whatwg/html/issues/11429
document->set_origin(associated_document.origin());
// 3. Return document.
return *document;
}