mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 01:29:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Sort text-decoration-line values in spec order

Browse source 
This wins us 49 WPT subtest passes! :^)
This commit is contained in:
Sam Atkins 2024-11-29 14:46:15 +00:00 • committed by Andreas Kling
commit 671d3e8a48
Notes: github-actions[bot] 2024-11-30 10:02:36 +00:00
3 changed files with 59 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/Enums.json
View file

@ -439,11 +439,11 @@
"-libweb-right" "-libweb-right"
], ],
"text-decoration-line": [ "text-decoration-line": [
"blink",
"line-through",
"none", "none",
"underline",
"overline", "overline",
"underline" "line-through",
"blink"
], ],
"text-decoration-style": [ "text-decoration-style": [
"dashed", "dashed",

5
Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -6384,6 +6384,11 @@ RefPtr<CSSStyleValue> Parser::parse_text_decoration_line_value(TokenStream<Compo
if (style_values.is_empty()) if (style_values.is_empty())
return nullptr; return nullptr;
quick_sort(style_values, [](auto& left, auto& right) {
return *keyword_to_text_decoration_line(left->to_keyword()) < *keyword_to_text_decoration_line(right->to_keyword());
});
return StyleValueList::create(move(style_values), StyleValueList::Separator::Space); return StyleValueList::create(move(style_values), StyleValueList::Separator::Space);
} }

102
Tests/LibWeb/Text/expected/wpt-import/css/css-text-decor/parsing/text-decoration-line-valid.txt
View file

@ -6,8 +6,8 @@ Rerun
Found 67 tests Found 67 tests
16 Pass 65 Pass
51 Fail 2 Fail
Details Details
Result Test Name MessagePass e.style['text-decoration-line'] = "none" should set the property value Result Test Name MessagePass e.style['text-decoration-line'] = "none" should set the property value
Pass e.style['text-decoration-line'] = "underline" should set the property value Pass e.style['text-decoration-line'] = "underline" should set the property value
@ -15,64 +15,64 @@ Pass e.style['text-decoration-line'] = "overline" should set the property value
Pass e.style['text-decoration-line'] = "line-through" should set the property value Pass e.style['text-decoration-line'] = "line-through" should set the property value
Pass e.style['text-decoration-line'] = "blink" should set the property value Pass e.style['text-decoration-line'] = "blink" should set the property value
Pass e.style['text-decoration-line'] = "underline overline" should set the property value Pass e.style['text-decoration-line'] = "underline overline" should set the property value
Fail e.style['text-decoration-line'] = "overline underline" should set the property value Pass e.style['text-decoration-line'] = "overline underline" should set the property value
Pass e.style['text-decoration-line'] = "underline line-through" should set the property value Pass e.style['text-decoration-line'] = "underline line-through" should set the property value
Fail e.style['text-decoration-line'] = "line-through underline" should set the property value Pass e.style['text-decoration-line'] = "line-through underline" should set the property value
Pass e.style['text-decoration-line'] = "underline blink" should set the property value Pass e.style['text-decoration-line'] = "underline blink" should set the property value
Fail e.style['text-decoration-line'] = "blink underline" should set the property value Pass e.style['text-decoration-line'] = "blink underline" should set the property value
Pass e.style['text-decoration-line'] = "overline line-through" should set the property value Pass e.style['text-decoration-line'] = "overline line-through" should set the property value
Fail e.style['text-decoration-line'] = "line-through overline" should set the property value Pass e.style['text-decoration-line'] = "line-through overline" should set the property value
Pass e.style['text-decoration-line'] = "overline blink" should set the property value Pass e.style['text-decoration-line'] = "overline blink" should set the property value
Fail e.style['text-decoration-line'] = "blink overline" should set the property value Pass e.style['text-decoration-line'] = "blink overline" should set the property value
Pass e.style['text-decoration-line'] = "line-through blink" should set the property value Pass e.style['text-decoration-line'] = "line-through blink" should set the property value
Fail e.style['text-decoration-line'] = "blink line-through" should set the property value Pass e.style['text-decoration-line'] = "blink line-through" should set the property value
Pass e.style['text-decoration-line'] = "underline overline line-through" should set the property value Pass e.style['text-decoration-line'] = "underline overline line-through" should set the property value
Fail e.style['text-decoration-line'] = "underline line-through overline" should set the property value Pass e.style['text-decoration-line'] = "underline line-through overline" should set the property value
Fail e.style['text-decoration-line'] = "overline underline line-through" should set the property value Pass e.style['text-decoration-line'] = "overline underline line-through" should set the property value
Fail e.style['text-decoration-line'] = "overline line-through underline" should set the property value Pass e.style['text-decoration-line'] = "overline line-through underline" should set the property value
Fail e.style['text-decoration-line'] = "line-through underline overline" should set the property value Pass e.style['text-decoration-line'] = "line-through underline overline" should set the property value
Fail e.style['text-decoration-line'] = "line-through overline underline" should set the property value Pass e.style['text-decoration-line'] = "line-through overline underline" should set the property value
Pass e.style['text-decoration-line'] = "underline overline blink" should set the property value Pass e.style['text-decoration-line'] = "underline overline blink" should set the property value
Fail e.style['text-decoration-line'] = "underline blink overline" should set the property value Pass e.style['text-decoration-line'] = "underline blink overline" should set the property value
Fail e.style['text-decoration-line'] = "overline underline blink" should set the property value Pass e.style['text-decoration-line'] = "overline underline blink" should set the property value
Fail e.style['text-decoration-line'] = "overline blink underline" should set the property value Pass e.style['text-decoration-line'] = "overline blink underline" should set the property value
Fail e.style['text-decoration-line'] = "blink underline overline" should set the property value Pass e.style['text-decoration-line'] = "blink underline overline" should set the property value
Fail e.style['text-decoration-line'] = "blink overline underline" should set the property value Pass e.style['text-decoration-line'] = "blink overline underline" should set the property value
Pass e.style['text-decoration-line'] = "underline line-through blink" should set the property value Pass e.style['text-decoration-line'] = "underline line-through blink" should set the property value
Fail e.style['text-decoration-line'] = "underline blink line-through" should set the property value Pass e.style['text-decoration-line'] = "underline blink line-through" should set the property value
Fail e.style['text-decoration-line'] = "line-through underline blink" should set the property value Pass e.style['text-decoration-line'] = "line-through underline blink" should set the property value
Fail e.style['text-decoration-line'] = "line-through blink underline" should set the property value Pass e.style['text-decoration-line'] = "line-through blink underline" should set the property value
Fail e.style['text-decoration-line'] = "blink underline line-through" should set the property value Pass e.style['text-decoration-line'] = "blink underline line-through" should set the property value
Fail e.style['text-decoration-line'] = "blink line-through underline" should set the property value Pass e.style['text-decoration-line'] = "blink line-through underline" should set the property value
Pass e.style['text-decoration-line'] = "overline line-through blink" should set the property value Pass e.style['text-decoration-line'] = "overline line-through blink" should set the property value
Fail e.style['text-decoration-line'] = "overline blink line-through" should set the property value Pass e.style['text-decoration-line'] = "overline blink line-through" should set the property value
Fail e.style['text-decoration-line'] = "line-through overline blink" should set the property value Pass e.style['text-decoration-line'] = "line-through overline blink" should set the property value
Fail e.style['text-decoration-line'] = "line-through blink overline" should set the property value Pass e.style['text-decoration-line'] = "line-through blink overline" should set the property value
Fail e.style['text-decoration-line'] = "blink overline line-through" should set the property value Pass e.style['text-decoration-line'] = "blink overline line-through" should set the property value
Fail e.style['text-decoration-line'] = "blink line-through overline" should set the property value Pass e.style['text-decoration-line'] = "blink line-through overline" should set the property value
Pass e.style['text-decoration-line'] = "underline overline line-through blink" should set the property value Pass e.style['text-decoration-line'] = "underline overline line-through blink" should set the property value
Fail e.style['text-decoration-line'] = "underline overline blink line-through" should set the property value Pass e.style['text-decoration-line'] = "underline overline blink line-through" should set the property value
Fail e.style['text-decoration-line'] = "underline line-through overline blink" should set the property value Pass e.style['text-decoration-line'] = "underline line-through overline blink" should set the property value
Fail e.style['text-decoration-line'] = "underline line-through blink overline" should set the property value Pass e.style['text-decoration-line'] = "underline line-through blink overline" should set the property value
Fail e.style['text-decoration-line'] = "underline blink overline line-through" should set the property value Pass e.style['text-decoration-line'] = "underline blink overline line-through" should set the property value
Fail e.style['text-decoration-line'] = "underline blink line-through overline" should set the property value Pass e.style['text-decoration-line'] = "underline blink line-through overline" should set the property value
Fail e.style['text-decoration-line'] = "overline underline line-through blink" should set the property value Pass e.style['text-decoration-line'] = "overline underline line-through blink" should set the property value
Fail e.style['text-decoration-line'] = "overline underline blink line-through" should set the property value Pass e.style['text-decoration-line'] = "overline underline blink line-through" should set the property value
Fail e.style['text-decoration-line'] = "overline line-through underline blink" should set the property value Pass e.style['text-decoration-line'] = "overline line-through underline blink" should set the property value
Fail e.style['text-decoration-line'] = "overline line-through blink underline" should set the property value Pass e.style['text-decoration-line'] = "overline line-through blink underline" should set the property value
Fail e.style['text-decoration-line'] = "overline blink underline line-through" should set the property value Pass e.style['text-decoration-line'] = "overline blink underline line-through" should set the property value
Fail e.style['text-decoration-line'] = "overline blink line-through underline" should set the property value Pass e.style['text-decoration-line'] = "overline blink line-through underline" should set the property value
Fail e.style['text-decoration-line'] = "line-through underline overline blink" should set the property value Pass e.style['text-decoration-line'] = "line-through underline overline blink" should set the property value
Fail e.style['text-decoration-line'] = "line-through underline blink overline" should set the property value Pass e.style['text-decoration-line'] = "line-through underline blink overline" should set the property value
Fail e.style['text-decoration-line'] = "line-through overline underline blink" should set the property value Pass e.style['text-decoration-line'] = "line-through overline underline blink" should set the property value
Fail e.style['text-decoration-line'] = "line-through overline blink underline" should set the property value Pass e.style['text-decoration-line'] = "line-through overline blink underline" should set the property value
Fail e.style['text-decoration-line'] = "line-through blink underline overline" should set the property value Pass e.style['text-decoration-line'] = "line-through blink underline overline" should set the property value
Fail e.style['text-decoration-line'] = "line-through blink overline underline" should set the property value Pass e.style['text-decoration-line'] = "line-through blink overline underline" should set the property value
Fail e.style['text-decoration-line'] = "blink underline overline line-through" should set the property value Pass e.style['text-decoration-line'] = "blink underline overline line-through" should set the property value
Fail e.style['text-decoration-line'] = "blink underline line-through overline" should set the property value Pass e.style['text-decoration-line'] = "blink underline line-through overline" should set the property value
Fail e.style['text-decoration-line'] = "blink overline underline line-through" should set the property value Pass e.style['text-decoration-line'] = "blink overline underline line-through" should set the property value
Fail e.style['text-decoration-line'] = "blink overline line-through underline" should set the property value Pass e.style['text-decoration-line'] = "blink overline line-through underline" should set the property value
Fail e.style['text-decoration-line'] = "blink line-through underline overline" should set the property value Pass e.style['text-decoration-line'] = "blink line-through underline overline" should set the property value
Fail e.style['text-decoration-line'] = "blink line-through overline underline" should set the property value Pass e.style['text-decoration-line'] = "blink line-through overline underline" should set the property value
Fail e.style['text-decoration-line'] = "spelling-error" should set the property value Fail e.style['text-decoration-line'] = "spelling-error" should set the property value
Fail e.style['text-decoration-line'] = "grammar-error" should set the property value Fail e.style['text-decoration-line'] = "grammar-error" should set the property value