mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

IPCCompiler: Don't silently ignore failure to encode IPC message

Browse source 
When message encoding failed for some reason, we'd just swallow the
error without saying a word, and carry on without sending anything.

This led to some very confusing situations.
This commit is contained in:
Andreas Kling 2024-12-17 19:13:52 +01:00 • committed by Andreas Kling
parent e74d8a6003
commit 6737b8b065
Notes: github-actions[bot] 2024-12-19 15:50:49 +00:00
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp
View file

@ -512,8 +512,7 @@ void do_message_for_proxy(SourceGenerator message_generator, Endpoint const& end
auto result = m_connection.template send_sync_but_allow_failure<Messages::@endpoint.name@::@message.pascal_name@>()~~~");
} else {
message_generator.append(R"~~~(
// FIXME: Handle post_message failures.
(void) m_connection.post_message(Messages::@endpoint.name@::@message.pascal_name@ { )~~~");
MUST(m_connection.post_message(Messages::@endpoint.name@::@message.pascal_name@ { )~~~");
}
for (size_t i = 0; i < parameters.size(); ++i) {
@ -555,7 +554,7 @@ void do_message_for_proxy(SourceGenerator message_generator, Endpoint const& end
return { };)~~~");
}
} else {
message_generator.appendln(" });");
message_generator.appendln(" }));");
}
message_generator.appendln(R"~~~(