mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-20 15:09:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Implement SVGLength's read-only property

Browse source 
An SVGLength can be read-only, e.g. all animVal values cannot be
modified. Implement this for all instantiations of SVGLength.

While we're here, add `fake_animated_length_fixme()` so we can easily
find all sites where we need to improve our animated length game.
This commit is contained in:
Jelle Raaijmakers 2025-08-26 16:51:46 +02:00 • committed by Jelle Raaijmakers
commit 676f5837b3
Notes: github-actions[bot] 2025-08-27 09:51:30 +00:00
16 changed files with 175 additions and 113 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/SVG/SVGAnimatedLength.cpp
View file

@ -14,16 +14,21 @@ GC_DEFINE_ALLOCATOR(SVGAnimatedLength);
GC::Ref<SVGAnimatedLength> SVGAnimatedLength::create(JS::Realm& realm, GC::Ref<SVGLength> base_val, GC::Ref<SVGLength> anim_val)
{
return realm.create<SVGAnimatedLength>(realm, move(base_val), move(anim_val));
return realm.create<SVGAnimatedLength>(realm, base_val, anim_val);
}
SVGAnimatedLength::SVGAnimatedLength(JS::Realm& realm, GC::Ref<SVGLength> base_val, GC::Ref<SVGLength> anim_val)
: PlatformObject(realm)
, m_base_val(move(base_val))
, m_anim_val(move(anim_val))
, m_base_val(base_val)
, m_anim_val(anim_val)
{
// The object referenced by animVal will always be distinct from the one referenced by baseVal, even when the attribute is not animated.
// The object referenced by animVal will always be distinct from the one referenced by baseVal, even when the
// attribute is not animated.
VERIFY(m_base_val.ptr() != m_anim_val.ptr());
// https://svgwg.org/svg2-draft/types.html#InterfaceSVGLength
// SVGLength objects reflected through the animVal IDL attribute are always read only.
VERIFY(m_anim_val->read_only() == SVGLength::ReadOnly::Yes);
}
SVGAnimatedLength::~SVGAnimatedLength() = default;
@ -34,7 +39,7 @@ void SVGAnimatedLength::initialize(JS::Realm& realm)
Base::initialize(realm);
}
void SVGAnimatedLength::visit_edges(Cell::Visitor& visitor)
void SVGAnimatedLength::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_base_val);