From 67800091c5272a5a27b4666cff4257283088d629 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Sun, 22 Dec 2024 22:30:45 +0100 Subject: [PATCH] LibWeb: Check for editability and visibility of "formattable nodes" The associated spec was only partially implemented. --- Libraries/LibWeb/Editing/Internal/Algorithms.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/Editing/Internal/Algorithms.cpp b/Libraries/LibWeb/Editing/Internal/Algorithms.cpp index 35ece3f7b91..3749eaf5444 100644 --- a/Libraries/LibWeb/Editing/Internal/Algorithms.cpp +++ b/Libraries/LibWeb/Editing/Internal/Algorithms.cpp @@ -1642,7 +1642,8 @@ bool is_extraneous_line_break(GC::Ref node) bool is_formattable_node(GC::Ref node) { // A formattable node is an editable visible node that is either a Text node, an img, or a br. - return is(*node) || is(*node) || is(*node); + return node->is_editable() && is_visible_node(node) + && (is(*node) || is(*node) || is(*node)); } // https://w3c.github.io/editing/docs/execCommand/#in-the-same-editing-host