mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Fix IDL Generation error for enums

Browse source 
In the case, where IDL enums start with a character, that is an invalid
start character for C++ identifiers (e.g. a number), the C++ generaion
for enums fails. An example would be "2d" see #3788
This commit is contained in:
Totto16 2025-03-04 01:04:18 +01:00 • committed by Tim Ledbetter
parent 1182ee6c69
commit 678f531fe5
Notes: github-actions[bot] 2025-03-04 08:32:26 +00:00
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Libraries/LibIDL/IDLParser.cpp
View file

@ -51,13 +51,42 @@
exit(EXIT_FAILURE);
}
static bool is_valid_cpp_identifier_start(char start)
{
// https://en.cppreference.com/w/cpp/language/identifiers
// to be a valid C++ identifier it must be a:
// uppercase Latin letter A-Z
// lowercase Latin letter a-z
if (is_ascii_alpha(start)) {
return true;
}
// underscore
if (start == '_') {
return true;
}
// FIXME: any Unicode character with the Unicode property XID_Start
return false;
}
static ByteString convert_enumeration_value_to_cpp_enum_member(ByteString const& value, HashTable<ByteString>& names_already_seen)
{
StringBuilder builder;
GenericLexer lexer { value };
bool first_word = true;
while (!lexer.is_eof()) {
lexer.ignore_while([](auto c) { return is_ascii_space(c) || c == '-' || c == '_'; });
if (first_word) {
auto const first_letter = lexer.peek();
if (!is_valid_cpp_identifier_start(first_letter))
builder.append('_');
first_word = false;
}
auto word = lexer.consume_while([](auto c) { return is_ascii_alphanumeric(c); });
if (!word.is_empty()) {
builder.append(word.to_titlecase_string());