mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 21:29:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS+LibLocale: Begin replacing number formatting with ICU

Browse source 
This uses ICU for the Intl.NumberFormat `format` and `formatToParts`
prototypes. It does not yet port the range formatter prototypes.

Most of the new code in LibLocale/NumberFormat is simply mapping from
ECMA-402 types to ICU types. Beyond that, the only algorithmic change is
that we have to mutate the output from ICU for `formatToParts` to match
what is expected by ECMA-402. This is explained in NumberFormat.cpp in
`flatten_partitions`.

This lets us remove most data from our number format generator. All that
remains are numbering system digits and symbols, which are relied upon
still for other interfaces (e.g. Intl.DateTimeFormat). So they will be
removed in a future patch.

Note: All of the changes to the test files in this patch are now aligned
with both Chrome and Safari.
This commit is contained in:
Timothy Flynn 2024-06-09 14:36:48 -04:00 • committed by Andreas Kling
commit 67f3de2320
Notes: sideshowbarker 2024-07-17 08:45:34 +09:00
24 changed files with 1168 additions and 2966 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.h
View file

@ -56,7 +56,8 @@ struct PatternPartition {
};
struct PatternPartitionWithSource : public PatternPartition {
static Vector<PatternPartitionWithSource> create_from_parent_list(Vector<PatternPartition> partitions)
template<typename ParentList>
static Vector<PatternPartitionWithSource> create_from_parent_list(ParentList partitions)
{
Vector<PatternPartitionWithSource> result;
result.ensure_capacity(partitions.size());