mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 02:09:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix incomplete plumbing for individual rotate CSS property

Browse source
This commit is contained in:
Andreas Kling 2024-11-22 16:11:33 +01:00 • committed by Andreas Kling
commit 6836d4edb1
Notes: github-actions[bot] 2024-11-22 19:07:55 +00:00
5 changed files with 27 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/Layout/Node.cpp
View file

@ -82,6 +82,8 @@ bool Node::can_contain_boxes_with_position_absolute() const
// Any computed value other than none for the transform affects containing block and stacking context
if (!computed_values().transformations().is_empty())
return true;
if (computed_values().rotate().has_value())
return true;
return false;
}
@ -175,6 +177,9 @@ bool Node::establishes_stacking_context() const
if (!computed_values().transformations().is_empty())
return true;
if (computed_values().rotate().has_value())
return true;
// Element that is a child of a flex container, with z-index value other than auto.
if (parent() && parent()->display().is_flex_inside() && computed_values().z_index().has_value())
return true;
@ -710,7 +715,7 @@ void NodeWithStyle::apply_style(const CSS::StyleProperties& computed_style)
computed_values.set_box_shadow(computed_style.box_shadow(*this));
if (auto rotate_value = computed_style.rotate(*this); rotate_value.has_value())
computed_values.set_rotate(rotate_value.value());
computed_values.set_rotate(rotate_value.release_value());
computed_values.set_transformations(computed_style.transformations());
if (auto transform_box = computed_style.transform_box(); transform_box.has_value())

9
Libraries/LibWeb/Layout/Node.h
View file

@ -178,7 +178,14 @@ public:
// https://www.w3.org/TR/CSS22/visuren.html#positioning-scheme
bool is_in_flow() const { return !is_out_of_flow(); }
bool has_css_transform() const { return computed_values().transformations().size() > 0; }
[[nodiscard]] bool has_css_transform() const
{
if (!computed_values().transformations().is_empty())
return true;
if (computed_values().rotate().has_value())
return true;
return false;
}
protected:
Node(DOM::Document&, DOM::Node*);