Userland: Avoid some conversions from rvalue strings to StringView

These are all actually fine, there is no UAF here. But once e.g. `ByteString::view() &&` is deleted, these instances won't compile.
Author: https://github.com/trflynn89 Commit: 683c08744a Pull-request: https://github.com/SerenityOS/serenity/pull/23830 Reviewed-by: https://github.com/shannonbooth ✅
2025-08-27 04:37:22 +00:00 · 2024-04-03 21:51:34 -04:00 · 2024-04-03 21:51:34 -04:00 · 683c08744a · 2024-07-17 03:59:29 +09:00
commit 683c08744a
parent 23b25333a5
17 changed files with 48 additions and 26 deletions
--- a/Userland/Libraries/LibWebSocket/WebSocket.cpp
+++ b/Userland/Libraries/LibWebSocket/WebSocket.cpp
@ -219,7 +219,7 @@ void WebSocket::send_client_handshake()
    builder.append("\r\n"sv);

    m_state = WebSocket::InternalState::WaitingForServerHandshake;
-    auto success = m_impl->send(builder.to_byte_string().bytes());
+    auto success = m_impl->send(builder.string_view().bytes());
    VERIFY(success);
 }