mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-03 22:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS/Bytecode: Make NewArray a variable-length instruction

Browse source 
This removes a layer of indirection in the bytecode where we had to make
sure all the initializer elements were laid out in sequential registers.

Array expressions no longer clobber registers permanently, and they can
be reused immediately afterwards.
This commit is contained in:
Andreas Kling 2024-05-08 12:43:08 +02:00
commit 6873628317
Notes: sideshowbarker 2024-07-17 03:59:29 +09:00
5 changed files with 40 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -254,13 +254,13 @@ public:
{
}
NewArray(Operand dst, AK::Array<Operand, 2> const& elements_range)
NewArray(Operand dst, ReadonlySpan<ScopedOperand> elements)
: Instruction(Type::NewArray)
, m_dst(dst)
, m_element_count(elements_range[1].index() - elements_range[0].index() + 1)
, m_element_count(elements.size())
{
m_elements[0] = elements_range[0];
m_elements[1] = elements_range[1];
for (size_t i = 0; i < m_element_count; ++i)
m_elements[i] = elements[i];
}
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
@ -270,19 +270,7 @@ public:
size_t length_impl() const
{
return round_up_to_power_of_two(alignof(void*), sizeof(*this) + sizeof(Operand) * (m_element_count == 0 ? 0 : 2));
}
Operand start() const
{
VERIFY(m_element_count);
return m_elements[0];
}
Operand end() const
{
VERIFY(m_element_count);
return m_elements[1];
return round_up_to_power_of_two(alignof(void*), sizeof(*this) + sizeof(Operand) * m_element_count);
}
size_t element_count() const { return m_element_count; }