From 68b57daf84d7802fa34da636e69c032f4c54d459 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Thu, 26 Jun 2025 14:23:00 +1200 Subject: [PATCH] LibURL: Remove uneeded FIXME for UTF-8 decode in URL parsing I believe this is in the specification since the spec technically requires passing through a valid unicode string. However, our implementation already handles a non valid unicode string, and will do the replacement character substitution. --- Libraries/LibURL/Parser.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibURL/Parser.cpp b/Libraries/LibURL/Parser.cpp index 281d8ce513c..09ddcc227bc 100644 --- a/Libraries/LibURL/Parser.cpp +++ b/Libraries/LibURL/Parser.cpp @@ -575,7 +575,8 @@ Optional Parser::parse_host(StringView input, bool is_opaque) // 3. Assert: input is not the empty string. VERIFY(!input.is_empty()); - // FIXME: 4. Let domain be the result of running UTF-8 decode without BOM on the percent-decoding of input. + // 4. Let domain be the result of running UTF-8 decode without BOM on the percent-decoding of input. + // NOTE: We do not need to do the UTF-8 decode without BOM as replacement is handled within domain_to_ascii. auto domain = percent_decode(input); // 5. Let asciiDomain be the result of running domain to ASCII with domain and false.