mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK: Convert Base64 template parameters to regular function parameters

Browse source 
The generated function name is otherwise very long, which makes stack
traces a bit more difficult to sift through.
This commit is contained in:
Timothy Flynn 2024-03-23 17:39:59 -04:00 • committed by Andreas Kling
commit 690db10463
Notes: sideshowbarker 2024-07-17 08:34:29 +09:00
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
AK/Base64.cpp
View file

@ -24,8 +24,7 @@ size_t calculate_base64_encoded_length(ReadonlyBytes input)
return ((4 * input.size() / 3) + 3) & ~3; return ((4 * input.size() / 3) + 3) & ~3;
} }
template<auto alphabet_lookup_table> static ErrorOr<ByteBuffer> decode_base64_impl(StringView input, ReadonlySpan<i16> alphabet_lookup_table)
ErrorOr<ByteBuffer> decode_base64_impl(StringView input)
{ {
auto get = [&](size_t& offset, bool* is_padding, bool& parsed_something) -> ErrorOr<u8> { auto get = [&](size_t& offset, bool* is_padding, bool& parsed_something) -> ErrorOr<u8> {
while (offset < input.length() && is_ascii_space(input[offset])) while (offset < input.length() && is_ascii_space(input[offset]))
@ -82,8 +81,7 @@ ErrorOr<ByteBuffer> decode_base64_impl(StringView input)
return output; return output;
} }
template<auto alphabet> static ErrorOr<String> encode_base64_impl(ReadonlyBytes input, ReadonlySpan<char> alphabet)
ErrorOr<String> encode_base64_impl(ReadonlyBytes input)
{ {
Vector<u8> output; Vector<u8> output;
TRY(output.try_ensure_capacity(calculate_base64_encoded_length(input))); TRY(output.try_ensure_capacity(calculate_base64_encoded_length(input)));
@ -121,21 +119,23 @@ ErrorOr<String> encode_base64_impl(ReadonlyBytes input)
ErrorOr<ByteBuffer> decode_base64(StringView input) ErrorOr<ByteBuffer> decode_base64(StringView input)
{ {
return decode_base64_impl<base64_lookup_table()>(input); static constexpr auto lookup_table = base64_lookup_table();
return decode_base64_impl(input, lookup_table);
} }
ErrorOr<ByteBuffer> decode_base64url(StringView input) ErrorOr<ByteBuffer> decode_base64url(StringView input)
{ {
return decode_base64_impl<base64url_lookup_table()>(input); static constexpr auto lookup_table = base64url_lookup_table();
return decode_base64_impl(input, lookup_table);
} }
ErrorOr<String> encode_base64(ReadonlyBytes input) ErrorOr<String> encode_base64(ReadonlyBytes input)
{ {
return encode_base64_impl<base64_alphabet>(input); return encode_base64_impl(input, base64_alphabet);
} }
ErrorOr<String> encode_base64url(ReadonlyBytes input) ErrorOr<String> encode_base64url(ReadonlyBytes input)
{ {
return encode_base64_impl<base64url_alphabet>(input); return encode_base64_impl(input, base64url_alphabet);
} }
} }