mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-03 08:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Replace ARIA “synonym” roles with their preferred synonyms

Browse source 
This change does replacement of ARIA roles that have newer synonyms.

There are a number of newer ARIA roles that are synonyms for older
roles. https://wpt.fyi/results/wai-aria/role/synonym-roles.html has a
number of subtests which expect that when retrieving the value of an
explicitly- specified role attribute, if the value is one of the older
role values, implementations must replace that with its newer synonym.
This commit is contained in:
sideshowbarker 2024-12-20 15:16:42 +09:00 • committed by Tim Flynn
commit 695ce3763e
Notes: github-actions[bot] 2024-12-20 13:46:50 +00:00
3 changed files with 60 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/ARIA/ARIAMixin.cpp
View file

@ -28,6 +28,20 @@ Optional<Role> ARIAMixin::role_from_role_attribute_value() const
auto role = role_from_string(role_name);
if (!role.has_value())
continue;
// NOTE: Per https://w3c.github.io/aria/#directory, "Authors are advised to treat directory as deprecated and to
// use 'list'." Further, the "directory role == computedrole list" and "div w/directory role == computedrole
// list" tests in https://wpt.fyi/results/wai-aria/role/synonym-roles.html expect "list", not "directory".
if (role == Role::directory)
return Role::list;
// NOTE: The "image" role value is a synonym for the older "img" role value; however, the "synonym img role ==
// computedrole image" test in https://wpt.fyi/results/wai-aria/role/synonym-roles.html expects "image", not "img".
if (role == Role::img)
return Role::image;
// NOTE: Per https://w3c.github.io/aria/#presentation, "the working group introduced none as the preferred
// synonym to the presentation role"; further, https://wpt.fyi/results/wai-aria/role/synonym-roles.html has a
// "synonym presentation role == computedrole none" test that expects "none", not "presentation".
if (role == Role::presentation)
return Role::none;
if (!is_abstract_role(*role))
return *role;
}

12
Tests/LibWeb/Text/expected/wpt-import/wai-aria/role/synonym-roles.txt Normal file
View file

@ -0,0 +1,12 @@
Harness status: OK
Found 7 tests
7 Pass
Pass image role == computedrole image
Pass synonym img role == computedrole image
Pass list role == computedrole list
Pass directory role == computedrole list
Pass div w/directory role == computedrole list
Pass none role == computedrole none
Pass synonym presentation role == computedrole none

34
Tests/LibWeb/Text/input/wpt-import/wai-aria/role/synonym-roles.html Normal file
View file

@ -0,0 +1,34 @@
<!doctype html>
<html>
<head>
<title>Region Role Verification Tests</title>
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../resources/testdriver.js"></script>
<script src="../../resources/testdriver-vendor.js"></script>
<script src="../../resources/testdriver-actions.js"></script>
<script src="../../wai-aria/scripts/aria-utils.js"></script>
</head>
<body>
<p>Tests synonym roles image/img and none/presentation via <a href="https://w3c.github.io/core-aam/#roleMappingComputedRole">Core-AAM Computed Role</a>.</p>
<!-- spec resolution https://github.com/w3c/core-aam/issues/166 -->
<div role="none" id="none" data-testname="none role == computedrole none" class="ex-generic">x</div><!-- preferred -->
<div role="presentation" id="presentation" data-testname="synonym presentation role == computedrole none" class="ex-generic">x</div><!-- synonym -->
<div role="image" id="image" data-expectedrole="image" data-testname="image role == computedrole image" class="ex">x</div><!-- preferred -->
<div role="img" id="img" data-expectedrole="image" data-testname="synonym img role == computedrole image" class="ex">x</div><!-- synonym -->
<!-- `directory` synonym deprecated in ARIA 1.2; these examples should all return computedrole `list` -->
<ul role="list" id="list2" data-expectedrole="list" data-testname="list role == computedrole list" class="ex"><li>x</li></ul>
<ul role="directory" id="directory" data-expectedrole="list" data-testname="directory role == computedrole list" class="ex"><li>x</li></ul>
<div role="directory" id="div" data-expectedrole="list" data-testname="div w/directory role == computedrole list" class="ex"><div role="listitem">x</div></div>
<script>
AriaUtils.verifyRolesBySelector(".ex");
AriaUtils.verifyGenericRolesBySelector(".ex-generic");
</script>
</body>
</html>